Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e test #115

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Fix e2e test #115

merged 4 commits into from
Aug 18, 2020

Conversation

slintes
Copy link
Contributor

@slintes slintes commented Aug 11, 2020 •
edited
Loading

Running the e2e test on OpenshiftCI revealed some issues:

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Aug 11, 2020
@slintes
Copy link
Contributor Author

slintes commented Aug 11, 2020

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 11, 2020
@slintes
Copy link
Contributor Author

slintes commented Aug 11, 2020

/test openshift-e2e

@kubevirt-bot
Copy link
Contributor

@slintes: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-node-maintenance-operator-e2e-k8s-1.18

Use /test all to run all jobs.

In response to this:

/test openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slintes
Copy link
Contributor Author

slintes commented Aug 17, 2020

/retest

@slintes
Give the PDB some time to be updated
4714f46 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes
Fixed operator namespace for getting logs
a56bbcf 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes slintes changed the title WIP Openshift CI test Fix e2e test Aug 17, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2020
@slintes
Fixed lease namespace (is the same as the operator ns)
8879962 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes
Copy link
Contributor Author

slintes commented Aug 17, 2020

/hold cancel

let's see if CI is green, if so: ready to be merged

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@slintes
Wait for webhook...
7a86b4d 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
beekhof
beekhof reviewed Aug 18, 2020
View reviewed changes
hack/sync-deploy.sh
# Fixme Webhook setup is slow... service needs to be created, endpoint needs to be created, and webhook server must be running
# Didn't find an easy but good solution yet, so just wait a bit for now
echo "[INFO] Giving the webhook some time to setup"
sleep 30s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A timeout is fine for now, but perhaps creating/deleting an invalid CRD in a loop until it fails would tell you when it's finally set up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

beekhof
beekhof approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@beekhof beekhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@beekhof
Copy link
Contributor

beekhof commented Aug 18, 2020

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beekhof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@kubevirt-bot kubevirt-bot merged commit 9142a03 into kubevirt:master Aug 18, 2020
@slintes slintes deleted the test-openshift-ci branch August 18, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhof beekhof beekhof approved these changes

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@beekhof beekhof

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slintes @kubevirt-bot @beekhof