Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knmstate: go 1.17 #1866

Closed
wants to merge 1 commit into from
Closed

knmstate: go 1.17 #1866

wants to merge 1 commit into from

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Jan 18, 2022

Use golang 1.17 for knmstate to check PR [1]

[1] nmstate/kubernetes-nmstate#963

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 18, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from qinqon after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon qinqon mentioned this pull request Jan 18, 2022
Merged
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@kubevirt-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

1 similar comment
@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@qinqon
knmstate: Install go from go.mod
e98a0a0 
Use golang specified at go.mod for to check PR [1]

[1] nmstate/kubernetes-nmstate#963

Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon
Copy link
Contributor Author

qinqon commented Jan 18, 2022

/rehearse

@kubevirt-bot
Copy link
Contributor

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-kubernetes-nmstate-e2e-handler-k8s-future 9f3838c link unknown /test pull-kubernetes-nmstate-e2e-handler-k8s-future
rehearsal-pull-kubernetes-nmstate-e2e-handler-k8s e98a0a0 link unknown /test pull-kubernetes-nmstate-e2e-handler-k8s
rehearsal-pull-kubernetes-nmstate-e2e-operator-k8s e98a0a0 link unknown /test pull-kubernetes-nmstate-e2e-operator-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qinqon qinqon closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil approved these changes

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@rhrazdil rhrazdil

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qinqon @kubevirt-bot @rhrazdil