Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CDI non-CSI lane #2795

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add CDI non-CSI lane #2795

merged 1 commit into from
Jun 1, 2023

Conversation

alromeros
Copy link
Contributor

This Pull Request adds a new testing lane for CDI with local Storage Class as default.

This non-CSI lane will allow us to keep testing the non-populator flow once kubevirt/containerized-data-importer#2722 is merged.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 30, 2023
@alromeros alromeros changed the title Add CDI local lane Add CDI local non-CSI lane May 30, 2023
@alromeros alromeros marked this pull request as ready for review May 30, 2023 17:10
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2023
@kubevirt-bot kubevirt-bot requested review from awels and maya-r May 30, 2023 17:10
mhenriks
mhenriks reviewed May 30, 2023
View reviewed changes
.../files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml Outdated
- "/usr/local/bin/runner.sh"
- "/bin/sh"
- "-c"
- "export TARGET=k8s-1.22 && automation/test.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some work, should reference a specific script in cdi repo for this test. Look at the current file for many examples

mhenriks
mhenriks reviewed May 30, 2023
View reviewed changes
.../files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml Outdated
@@ -414,3 +414,36 @@ presubmits:
- name: kubevirtci-fossa
secret:
secretName: kubevirtci-fossa-token
- name: pull-containerized-data-importer-non-csi-k8s-local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we discuss the benefits of local vs old (non csi) hpp? I don't have much of a preference. But hpp is nice because it's a real dynamic provisioner. With local, could maybe run out of volumes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use classic hpp since it seemed to be the favorite among the team.

@alromeros alromeros changed the title Add CDI local non-CSI lane Add CDI non-CSI lane May 31, 2023
@alromeros alromeros marked this pull request as draft June 1, 2023 09:43
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2023
@alromeros
Add CDI non-CSI HPP lane
f3ac7e5 
This commit adds a new testing lane for CDI with hostpath-provisioner as default SC.

This allows us to have a non-CSI lane to test the non-populator flow.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros alromeros marked this pull request as ready for review June 1, 2023 14:41
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2023
@alromeros
Copy link
Contributor Author

/test pull-project-infra-prow-deploy-test

@mhenriks
Copy link
Member

mhenriks commented Jun 1, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@kubevirt-bot kubevirt-bot merged commit 28fa3ac into kubevirt:main Jun 1, 2023
@kubevirt-bot
Copy link
Contributor

@alromeros: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key containerized-data-importer-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml

In response to this:

This Pull Request adds a new testing lane for CDI with local Storage Class as default.

This non-CSI lane will allow us to keep testing the non-populator flow once kubevirt/containerized-data-importer#2722 is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@awels awels Awaiting requested review from awels

@maya-r maya-r Awaiting requested review from maya-r

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@mhenriks mhenriks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alromeros @kubevirt-bot @mhenriks