-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDI non-CSI lane #2795
Add CDI non-CSI lane #2795
Conversation
Skipping CI for Draft Pull Request. |
6298f70
to
72b238a
Compare
- "/usr/local/bin/runner.sh" | ||
- "/bin/sh" | ||
- "-c" | ||
- "export TARGET=k8s-1.22 && automation/test.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some work, should reference a specific script in cdi repo for this test. Look at the current file for many examples
@@ -414,3 +414,36 @@ presubmits: | |||
- name: kubevirtci-fossa | |||
secret: | |||
secretName: kubevirtci-fossa-token | |||
- name: pull-containerized-data-importer-non-csi-k8s-local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we discuss the benefits of local vs old (non csi) hpp? I don't have much of a preference. But hpp is nice because it's a real dynamic provisioner. With local, could maybe run out of volumes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll use classic hpp since it seemed to be the favorite among the team.
72b238a
to
913da4a
Compare
This commit adds a new testing lane for CDI with hostpath-provisioner as default SC. This allows us to have a non-CSI lane to test the non-populator flow. Signed-off-by: Alvaro Romero <alromero@redhat.com>
913da4a
to
f3ac7e5
Compare
/test pull-project-infra-prow-deploy-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alromeros: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This Pull Request adds a new testing lane for CDI with
local
Storage Class as default.This non-CSI lane will allow us to keep testing the non-populator flow once kubevirt/containerized-data-importer#2722 is merged.