-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable make unittest for different architectures. #1000
fix: enable make unittest for different architectures. #1000
Conversation
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8f4995a
to
1134a4e
Compare
@nestoracunablanco Thanks for your PR. Please, signoff your commit. |
1134a4e
to
bcfc6dd
Compare
@jcanocan commit already signed off. |
Great, thanks. Release note is also required. Please, add it. It could be just None. |
/ok-to-test |
/retest-required |
bcfc6dd
to
291073f
Compare
/release-note-none |
@nestoracunablanco Thanks a lot for your contribution! |
Thanks @jcanocan , may I implement the suggestion from @codingben or do you prefer another PR for that? |
Fair point! Missed @codingben's comment. Please, do it in this PR if that's ok to you as well. |
Prometheus was downloaded only for amd64. The make unittest calls the tool under the hood. This fix enables the download for another architectures. Signed-off-by: Nestor Acuna Blanco <Nestor.Acuna@ibm.com>
291073f
to
a55e2cb
Compare
The suggestion from @codingben has been implemented, @jcanocan. Thank you for your review. |
Nice job @nestoracunablanco! |
/cc @0xFelix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prometheus was downloaded only for amd64. The make unittest
calls the tool under the hood. This fix enables the download for
another architectures.
Signed-off-by: Nestor Acuna Blanco Nestor.Acuna@ibm.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: