Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable make unittest for different architectures. #1000

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: enable make unittest for different architectures. #1000

merged 1 commit into from
Jun 27, 2024

Conversation

nestoracunablanco
Copy link
Contributor

@nestoracunablanco nestoracunablanco commented Jun 25, 2024 •
edited

Prometheus was downloaded only for amd64. The make unittest
calls the tool under the hood. This fix enables the download for
another architectures.

Signed-off-by: Nestor Acuna Blanco Nestor.Acuna@ibm.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2024
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 25, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco nestoracunablanco changed the title fix: enable make unittest enabled for different architctures. fix: enable make unittest for different architectures. Jun 25, 2024
@jcanocan
Copy link
Contributor

jcanocan commented Jun 25, 2024 •
edited

@nestoracunablanco Thanks for your PR. Please, signoff your commit.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 25, 2024
@nestoracunablanco
Copy link
Contributor Author

@jcanocan commit already signed off.

codingben
codingben reviewed Jun 25, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@jcanocan
Copy link
Contributor

@jcanocan commit already signed off.

Great, thanks. Release note is also required. Please, add it. It could be just None.

@jcanocan
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2024
@jcanocan
Copy link
Contributor

/retest-required

@nestoracunablanco
Copy link
Contributor Author

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 26, 2024
@jcanocan
Copy link
Contributor

@nestoracunablanco Thanks a lot for your contribution!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@nestoracunablanco
Copy link
Contributor Author

Thanks @jcanocan , may I implement the suggestion from @codingben or do you prefer another PR for that?

@jcanocan
Copy link
Contributor

Thanks @jcanocan , may I implement the suggestion from @codingben or do you prefer another PR for that?

Fair point! Missed @codingben's comment. Please, do it in this PR if that's ok to you as well.

@nestoracunablanco
fix: enable make unittest for different architectures.
a55e2cb 
Prometheus was downloaded only for amd64. The make unittest
calls the tool under the hood. This fix enables the download for
another architectures.

Signed-off-by: Nestor Acuna Blanco <Nestor.Acuna@ibm.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@nestoracunablanco
Copy link
Contributor Author

The suggestion from @codingben has been implemented, @jcanocan. Thank you for your review.

@jcanocan
Copy link
Contributor

Nice job @nestoracunablanco!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@jcanocan
Copy link
Contributor

/cc @0xFelix
Please, take a look!

0xFelix
0xFelix approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@kubevirt-bot kubevirt-bot merged commit 0592ead into kubevirt:main Jun 27, 2024
8 checks passed
@nestoracunablanco nestoracunablanco deleted the fix/unittests-multiarch branch June 28, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingben codingben codingben left review comments

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@0xFelix 0xFelix

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nestoracunablanco @jcanocan @kubevirt-bot @0xFelix @codingben