feat: rework example pipelines #550

ksimon1 · 2023-05-22T12:08:47Z

What this PR does / why we need it:
feat: rework example pipelines

Common-templates are going to be deprecated in some future version. This commit is changing example pipelines to remove all automation related to templates and replaces it with create-vm-from-manifest task.

This change helps to unify pipelines for okd and kubernetes, so now we can use single version for okd and k8s.

Release note:

Remove templates automation from example pipelines

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

0xFelix · 2023-05-23T07:07:17Z

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

+metadata:
+  name: pipeline
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole


Do we still need to ship this role or was this fixed in Tekton/OpenShift Pipelines in the meantime?

yes, we still need it - I tested it with openshift pipelines 1.10.2 (newest) and SA is still not deployed to openshift|kube namespaces

0xFelix · 2023-05-23T07:08:04Z

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

+    - name: virtioContainerDiskName
+      description: Reference to the containerdisk containing the virtio-win drivers ISO.
+      type: string
+      default: quay.io/kubevirt/virtio-container-disk:latest


The latest tag hasn't been updated in two years. This could be an issue.

It can't because the value is replaced by https://github.com/kubevirt/ssp-operator/blob/master/internal/operands/tekton-pipelines/tekton-pipelines.go#L161

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

0xFelix · 2023-05-23T07:11:24Z

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

+      taskRef:
+        kind: Task
+        name: wait-for-vmi-status
+    - name: create-base-dv


Isn't the base-dv enough, why do we need a separate root disk that is cloned after the install? Can't the base-dv be used as root disk directly?

All gets complicated, because of the disk name and multiple runs use case. In templates, the disk name was derived from VM name and vm name was generated with some random hash. So you could run the pipeline multiple times. But while creating VM from VM manifest, the datavolume can have only a single hardcoded name (it might use generateName, but then we could not copy it to kubevirt-os-images, because the pvc will have different name than VM and vm name and namespace is the only information we get from create-vm task).

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

0xFelix · 2023-05-23T07:17:05Z

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

+    - description: Namespace of the created base DataVolume
+      name: baseDvNamespace
+      value: $(tasks.create-base-dv.results.namespace)
+  tasks:


Put this block at the start of the pipeline spec?

I prefer the order: params, tasks, finally, results

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

0xFelix · 2023-05-23T07:17:53Z

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

+        kind: Task
+        name: wait-for-vmi-status
+      timeout: 2h0m0s
+    - name: create-base-dv


As above, is cloning twice really necessary?

It might be possible to do a single copy, but I need to test it, because it will mean to run VM in kubevirt-os-images namespace

Bios installer is not cloing twice while efi installer still is?

efi installer has to clone twice due to the fact, that pipelineRun can run in any namespace. One of the efi pipelineRun pod is mounting the PVC with iso. The PVC has to be in the same namespace as the pod (cross namespace is not supported during mount). So at the end when VM is finished, the result PVC has to be copied to result namespace.

ksimon1 · 2023-05-25T11:22:25Z

/hold I need to do additional changes

ksimon1 · 2023-06-01T16:54:49Z

/retest

ksimon1 · 2023-06-02T17:04:19Z

/hold cancel

ksimon1 · 2023-06-05T07:38:53Z

@akrejcir, @jcanocan, @opokornyy can you please review?

ksimon1 · 2023-06-05T07:58:30Z

/retest

0xFelix · 2023-06-05T08:18:38Z

automation/e2e-tekton/example-pipelines-test.sh

@@ -29,17 +29,22 @@ done
 # SECRET
 accessKeyId="/tmp/secrets/accessKeyId"
 secretKey="/tmp/secrets/secretKey"
+namespace="kubevirt"


Use different namespace to test pipelines by default?

0xFelix · 2023-06-05T08:21:34Z

data/tekton-pipelines/pipelines-rbac.yaml

+    name: pipeline
+---
+apiVersion: v1
+kind: ServiceAccount


Can this become an issue when pipeline SA is already there, i.e. will ssp-operator and tektoncd/operator fight for it?

Currently the SA is deployed only to ^openshift|^kube namespace. Howewer in the future there might be a time, when this bug will be fixed and ssp and tekton operator will fight over this SA. I will add a check to ssp if the SA already exists

data/tekton-pipelines/windows-bios-installer-pipeline.yaml

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

0xFelix · 2023-06-06T12:12:01Z

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

+            kind: DataVolume
+            metadata:
+              annotations:
+                "cdi.kubevirt.io/storage.bind.immediate.requested": "true"


Quotes used here but in L187 not?

Good catch, I updated it, but for some unknow reasons, it was reverted back

0xFelix · 2023-06-06T12:12:22Z

data/tekton-pipelines/windows-efi-installer-pipeline.yaml

+        kind: Task
+        name: wait-for-vmi-status
+      timeout: 2h0m0s
+    - name: create-base-dv


internal/operands/tekton-pipelines/tekton-pipelines.go

tests/tekton-pipelines_test.go

ksimon1 · 2023-06-12T13:07:04Z

/retest

ksimon1 · 2023-06-12T13:07:16Z

/retest

0xFelix

Looks good to me.

/approve

kubevirt-bot · 2023-06-12T14:31:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ksimon1 · 2023-06-13T05:55:04Z

/retest

ksimon1 · 2023-06-13T09:35:10Z

/retest

ksimon1 · 2023-06-14T07:02:03Z

/retest

Common-templates are going to be deprecated in some future version. This commit is changing example pipelines to remove all automation related to templates and replaces it with create-vm-from-manifest task. This change helps to unify pipelines for okd and kubernetes, so now we can use single version for okd and k8s. windows-bios-installer pipeline is redesigned to run only in a single namespace, which helps to reduce number of steps and complexity. windows-customize pipeline is redesigned to run only in a single namespace which helps to reduce number of steps and complexity. Due to changes in pipelines, there were done necessary changes in RBAC - objects separated in different file, rules defined in bios-installer pipeline were replaced by roleBindings to original task's clusterRoles. Signed-off-by: Karel Šimon <ksimon@redhat.com>

sonarcloud · 2023-06-14T16:18:21Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

akrejcir · 2023-06-15T06:27:03Z

/lgtm

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 22, 2023

kubevirt-bot requested review from 0xFelix and akrejcir May 22, 2023 12:08

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL labels May 22, 2023

0xFelix reviewed May 23, 2023

View reviewed changes

ksimon1 force-pushed the update-pipelines branch from 9439e2a to f90197c Compare May 25, 2023 11:18

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023

ksimon1 force-pushed the update-pipelines branch 4 times, most recently from 30b2bef to e7a11f3 Compare June 1, 2023 11:30

ksimon1 force-pushed the update-pipelines branch 4 times, most recently from 3a768fb to 90dfa29 Compare June 2, 2023 17:03

ksimon1 changed the title ~~[WIP] feat: rework example pipelines~~ feat: rework example pipelines Jun 2, 2023

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023

0xFelix reviewed Jun 5, 2023

View reviewed changes

ksimon1 force-pushed the update-pipelines branch 3 times, most recently from 4b77915 to 10a3448 Compare June 6, 2023 10:51

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023

ksimon1 force-pushed the update-pipelines branch from 10a3448 to 0d8cdd8 Compare June 6, 2023 10:54

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023

0xFelix reviewed Jun 6, 2023

View reviewed changes

ksimon1 force-pushed the update-pipelines branch 2 times, most recently from 5683820 to dec3e9a Compare June 12, 2023 10:51

0xFelix reviewed Jun 12, 2023

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023

ksimon1 force-pushed the update-pipelines branch from dec3e9a to 15722e9 Compare June 13, 2023 10:52

ksimon1 force-pushed the update-pipelines branch 2 times, most recently from f5a3692 to 994357d Compare June 14, 2023 16:02

ksimon1 force-pushed the update-pipelines branch from 994357d to 14fbce5 Compare June 14, 2023 16:03

kubevirt-bot assigned akrejcir Jun 15, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023

kubevirt-bot merged commit 4617093 into kubevirt:master Jun 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rework example pipelines #550

feat: rework example pipelines #550

ksimon1 commented May 22, 2023

0xFelix May 23, 2023

ksimon1 May 23, 2023

0xFelix May 23, 2023

ksimon1 May 23, 2023

0xFelix May 23, 2023

ksimon1 May 25, 2023

0xFelix May 23, 2023

ksimon1 May 25, 2023

0xFelix May 23, 2023

ksimon1 May 25, 2023

0xFelix Jun 5, 2023

ksimon1 Jun 5, 2023

0xFelix Jun 6, 2023

ksimon1 commented May 25, 2023

ksimon1 commented Jun 1, 2023

ksimon1 commented Jun 2, 2023

ksimon1 commented Jun 5, 2023

ksimon1 commented Jun 5, 2023

0xFelix Jun 5, 2023

0xFelix Jun 5, 2023

ksimon1 Jun 5, 2023

0xFelix Jun 6, 2023

ksimon1 Jun 6, 2023

0xFelix Jun 6, 2023

ksimon1 commented Jun 12, 2023

ksimon1 commented Jun 12, 2023

0xFelix left a comment

kubevirt-bot commented Jun 12, 2023

ksimon1 commented Jun 13, 2023

ksimon1 commented Jun 13, 2023

ksimon1 commented Jun 14, 2023

sonarcloud bot commented Jun 14, 2023

akrejcir commented Jun 15, 2023

feat: rework example pipelines #550

feat: rework example pipelines #550

Conversation

ksimon1 commented May 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksimon1 commented May 25, 2023

ksimon1 commented Jun 1, 2023

ksimon1 commented Jun 2, 2023

ksimon1 commented Jun 5, 2023

ksimon1 commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksimon1 commented Jun 12, 2023

ksimon1 commented Jun 12, 2023

0xFelix left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Jun 12, 2023

ksimon1 commented Jun 13, 2023

ksimon1 commented Jun 13, 2023

ksimon1 commented Jun 14, 2023

sonarcloud bot commented Jun 14, 2023

akrejcir commented Jun 15, 2023