-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add checking that all files are committed #565
Conversation
3ac2424
to
d8710a9
Compare
1674124
to
83f94f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a more generic kind of job which runs all make targets generating or downloading stuff and that checks if the tree is clean after?
40daef3
to
bd6e236
Compare
|
||
check_make vendor | ||
check_make generate | ||
check_make manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add check_make fmt
?
This commit modifies the Makefile to execute script that checks whether all generated files are committed. Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
bd6e236
to
e019de1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR modifies the Makefile to execute script that checks whether all files are committed.
Release note: