Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency go to v1.23.0 #353

Merged
merged 16 commits into from
Aug 21, 2024
Merged

chore(deps): update dependency go to v1.23.0 #353

merged 16 commits into from
Aug 21, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 13, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
go (source) toolchain minor 1.22.6 -> 1.23.0

Release Notes

golang/go (go)

v1.23.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Aug 13, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: install-tool golang 1.23.0

1.21 EOL yesterday (2024-08-13).

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Copy link
Contributor Author

renovate bot commented Aug 14, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 2.04082% with 96 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (ebdb7e1) to head (2f137b1).
Report is 25 commits behind head on main.

Files Patch % Lines
cmd/root.go 0.00% 82 Missing ⚠️
internal/log/level.go 0.00% 5 Missing ⚠️
internal/scanner/scanner.go 28.57% 5 Missing ⚠️
internal/policies/client.go 0.00% 2 Missing ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   70.24%   69.21%   -1.04%     
==========================================
  Files          11       11              
  Lines        1089     1098       +9     
==========================================
- Hits          765      760       -5     
- Misses        252      266      +14     
  Partials       72       72              
Flag Coverage Δ
unit-tests 69.21% <2.04%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccuad viccuad self-assigned this Aug 19, 2024
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
This is needed so the build that golangci-lint uses includes
internal/testutils, as that package is used by all the tests.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
See golangci/golangci-lint#166.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
See: kyoh86/exportloopref#25

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
reduce number of lines

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
This function and related would need quite a refactor to reduce the
complexity. Punting on it for now.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Makes golangci-lint gochecknoglobals happy.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
We are not going to create a struct to hold the flags for now and split
this function; we have only 1 command and we test the logic in the other
packages.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
.golangci.yml Show resolved Hide resolved
@viccuad viccuad requested a review from jvanz August 21, 2024 07:34
@jvanz jvanz merged commit 9a4afa1 into main Aug 21, 2024
7 of 9 checks passed
@renovate renovate bot deleted the renovate/go-1.x branch August 21, 2024 13:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants