Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify namespaceObject lazy-loading #69

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

fabriziosestito
Copy link
Contributor

Description

Simplify the lazy-loading of namespaceObject removing the custom type in favour of a simple function, as done for the variables in #57

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito fabriziosestito self-assigned this Jul 12, 2024
@fabriziosestito fabriziosestito requested a review from a team July 12, 2024 08:12
@viccuad
Copy link
Member

viccuad commented Jul 12, 2024

DCO is stuck on "expected" but it works for other PRs (see #70)

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

@flavio flavio merged commit 096d383 into main Jul 12, 2024
8 checks passed
@flavio flavio deleted the refactor/simplify-namespaceObject-lazy-loading branch July 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants