Script to update third_party directory. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanz
force-pushed
the
main
branch
3 times, most recently
from
297ffd6 to
f3b79b5
Compare
|
I think that the e2e tests are facing the same issue reported here |
fabriziosestito
approved these changes
Sep 5, 2024
|
|
||
| # Check if the base directory exists | ||
| if [ ! -d "$REPOSITORY_DIR" ]; then | ||
| echo "Error: Base directory $base_directory does not exist." |
There was a problem hiding this comment.
where does $base_directory come from?
There was a problem hiding this comment.
+1 here
what happen if $base_directory is unset?
Since you are using bash, you could leverage parameter substitution as explained on
https://tldp.org/LDP/abs/html/parameter-substitution.html
I usually like to start my bash script with
set -eux
There was a problem hiding this comment.
Ops, copy and paste problems. Sorry. Let me fix it .
flavio
reviewed
Sep 5, 2024
Adds a new updatecli script to update the third_party directory files with the latest releases of the apiserver and apimachinery. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com> Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
flavio
approved these changes
Sep 6, 2024
fabriziosestito
approved these changes
Sep 6, 2024
Updates the Github actions to get the Sigstore fix and make kwctl able to run the policy again. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new updatecli script to update the third_party directory files with the latest releases of the apiserver and apimachinery.
Fix #72
It's possible to see the CI job and the consequent PR generated using the initial version of this PR in my fork.