Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third_party directory with files from Kubernetes v1.31.0 #83

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2024

Automatic third_party directory update with the files from the Kubernetes v1.31.0.

REMEMBER IF YOU WANT TO MERGE IN A SINGLE COMMIT CHANGES AND VERSION BUMP, YOU MUST SQUASH THE COMMIT BEFORE MERGING THIS PR!


Update the third party directory with files from Kubernetes repositories

Get latest apiserver files

ran shell command "bash updatecli/scripts/install-third-party.sh"

Get latest apimachinery files

ran shell command "bash updatecli/scripts/install-third-party.sh"

Update third party directory README file

1 file(s) updated with "This folder contains third-party code from kubernetes:\n\n- [kubernetes/apiserver](https://github.com/kubernetes/apiserver).\n- [kubernetes/apimachinery](https://github.com/kubernetes/apimachinery).\n\nThe current version is based on kubernetes v1.31.0 (apiserver/apimachinery v0.31.0).\n\nAll code in this folder is licensed under the Apache License 2.0, see [LICENSE](LICENSE).\n": * ./third_party/README.md

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

Made with ❤️️ by updatecli

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Made with ❤️️ by updatecli

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Made with ❤️️ by updatecli

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
@jvanz jvanz force-pushed the updatecli_main_166a5703c3367385967dba81feafe6a23affcb71b79a70cdaf654a33cc886556 branch from 7d36a55 to 913565a Compare September 9, 2024 18:03
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a final question.

When I checked out the PR and run go mod tidy, I saw a change to the go.sum file:

diff --git a/go.sum b/go.sum
index 3e181ca..2680692 100644
--- a/go.sum
+++ b/go.sum
@@ -6,8 +6,6 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
 github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
-github.com/google/cel-go v0.20.1 h1:nDx9r8S3L4pE61eDdt8igGj8rf5kjYR3ILxWIpWNi84=
-github.com/google/cel-go v0.20.1/go.mod h1:kWcIzTsPX0zmQ+H3TirHstLLf9ep5QTsZBN9u4dOYLg=
 github.com/google/cel-go v0.21.0 h1:cl6uW/gxN+Hy50tNYvI691+sXxioCnstFzLp2WO4GCI=
 github.com/google/cel-go v0.21.0/go.mod h1:rHUlWCcBKgyEk+eV03RPdZUekPp6YcJwV0FxuUksYxc=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=

Should we change the update-cli job to run go mod tidy too?

Comment on lines +28 to +37
var celReservedSymbols = sets.NewString(
"true", "false", "null", "in",
"as", "break", "const", "continue", "else",
"for", "function", "if", "import", "let",
"loop", "package", "namespace", "return", // !! 'namespace' is used heavily in Kubernetes
"var", "void", "while",
)

// expandMatcher matches the escape sequence, characters that are escaped, and characters that are unsupported
var expandMatcher = regexp.MustCompile(`(__|[-./]|[^a-zA-Z0-9-./_])`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriziosestito not related with this PR, but interesting to know the validation rule of CEL expressions. I'm thinking about the group policy validation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one! I think I stumbled into this but completely forgot about it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's nice. We can use this as a base for our changes. As expected, it's matches the language def

@@ -25,6 +25,8 @@ import (
"strconv"
"strings"

cbor "k8s.io/apimachinery/pkg/runtime/serializer/cbor/direct"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that would have introduced a new dependency, but that's not true.

I checked-out the PR, run go mod tidy and then inspected the go.sum but I didn't find any reference to github.com/fxamacker/cbor/v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #84 that runs go mod tidy.

The automation script forgot to do that

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio
Copy link
Member

flavio commented Sep 10, 2024

I've pushed the changes done by go mod tidy

@flavio flavio merged commit ca00ec1 into main Sep 10, 2024
9 checks passed
@flavio flavio deleted the updatecli_main_166a5703c3367385967dba81feafe6a23affcb71b79a70cdaf654a33cc886556 branch September 10, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants