Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNCF suggests adding benefits/value proposition section to introduction #530

Merged
merged 5 commits into from
Jan 29, 2025
Merged

CNCF suggests adding benefits/value proposition section to introduction #530

merged 5 commits into from
Jan 29, 2025

Conversation

jhkrug
Copy link
Contributor

@jhkrug jhkrug commented Jan 28, 2025

Replaced the few bits in the opening section with something a little more comprehensive.

Resolves #529

@jhkrug
CNCF suggest adding benefits/value poposition section to introduction
ba65fc7 
Signed-off-by: John Krug <john.krug@suse.com>
@jhkrug jhkrug added the area/documentation Improvements or additions to documentation label Jan 28, 2025
@jhkrug jhkrug self-assigned this Jan 28, 2025
@jhkrug jhkrug requested a review from a team as a code owner January 28, 2025 13:01
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for docs-kubewarden-io ready!

Name Link
🔨 Latest commit d93a9a6
🔍 Latest deploy log https://app.netlify.com/sites/docs-kubewarden-io/deploys/6799efd10a053e0008e8a840
😎 Deploy Preview https://deploy-preview-530--docs-kubewarden-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jvanz
jvanz approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhkrug jhkrug marked this pull request as draft January 28, 2025 14:11
@jhkrug
Changed wording and added use cases.
7bca1c5 
Signed-off-by: John Krug <john.krug@suse.com>
@jhkrug jhkrug marked this pull request as ready for review January 28, 2025 14:40
@jhkrug jhkrug requested a review from jvanz January 28, 2025 22:00
dariavladykina
dariavladykina reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see some suggestions here. Thanks!

docs/introduction.md Outdated Show resolved Hide resolved
docs/introduction.md Outdated Show resolved Hide resolved
docs/introduction.md Outdated Show resolved Hide resolved
jhkrug and others added 3 commits January 29, 2025 10:06
@jhkrug @dariavladykina
Update docs/introduction.md
ecc9435 
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
@jhkrug @dariavladykina
Update docs/introduction.md
95fe4fb 
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
@jhkrug @dariavladykina
Update docs/introduction.md
d93a9a6 
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
@flavio flavio merged commit 3328f3d into kubewarden:main Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariavladykina dariavladykina dariavladykina left review comments

@viccuad viccuad viccuad approved these changes

@jvanz jvanz jvanz approved these changes

@flavio flavio flavio approved these changes

Assignees

@jhkrug jhkrug

Labels
area/documentation Improvements or additions to documentation
Projects
Kubewarden
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KW value proposition - CNCF
5 participants
@jhkrug @flavio @jvanz @viccuad @dariavladykina