-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump controller-runtime #533
Conversation
5896c1a
to
8d5cede
Compare
8d5cede
to
caaf8e1
Compare
This PR passed all the e2e tests. NOTE: This PR should be merged after this one in order to allow run the controller on development environment. |
@@ -172,7 +171,7 @@ func (r *PolicyServerReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
}, | |||
} | |||
})). | |||
Watches(&source.Kind{Type: &policiesv1.ClusterAdmissionPolicy{}}, handler.EnqueueRequestsFromMapFunc(func(object client.Object) []reconcile.Request { | |||
Watches(&policiesv1.ClusterAdmissionPolicy{}, handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, object client.Object) []reconcile.Request { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been trying to understand from where these contexts come now, as they now seem to come from the Controller. Particularly, I am wondering on what happens if they timeout, as we could stop processing request through the webhook correctly and lock the cluster.
I have only come by this: kubernetes-sigs/controller-runtime#1334.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case, on the daily we agreed that this question should not block the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 1 question about the new context usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the hard work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Bumps the controller-runtime dependency in use to v0.16.2. This required change in how we configure the controllers manager. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
caaf8e1
to
04b6009
Compare
Description
Bumps the controller-runtime dependency in use to v0.16.2. This required change in how we configure the controllers manager.
Related to kubewarden/audit-scanner#39
Test
make test
Additional Information
This PR need to be updated and merged after merging the PR updating the
kube-webhook-wrapper
.