-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: its not necessary add the finalizer in the reconciliation loop. #779
fix: its not necessary add the finalizer in the reconciliation loop. #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The finalizer used by the Kubewarden controller is added in the webhook for the policy server and policies types. Therefore, it not needed to add it in the reconciliation loop. Furthermore, the deletion reconciliation is able to handle old finalizer as well. So, this change will not cause issues when deleting resources. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
b5de863
to
79b9aaf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 74.28% 73.39% -0.89%
==========================================
Files 28 28
Lines 1816 1808 -8
==========================================
- Hits 1349 1327 -22
- Misses 352 363 +11
- Partials 115 118 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The finalizer used by the Kubewarden controller is added in the webhook for the policy server and policies types. Therefore, it not needed to add it in the reconciliation loop. Furthermore, the deletion reconciliation is able to handle old finalizer as well. So, this change will not cause issues when deleting resources.