feat: use stricter go linter configuration. #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
==========================================
- Coverage 70.37% 70.33% -0.05%
==========================================
Files 19 19
Lines 1708 1719 +11
==========================================
+ Hits 1202 1209 +7
- Misses 388 393 +5
+ Partials 118 117 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flavio
approved these changes
Jul 11, 2024
fabriziosestito
approved these changes
Jul 12, 2024
viccuad
approved these changes
Jul 12, 2024
jvanz
force-pushed
the
issue778-golint
branch
2 times, most recently
from
838497f
to
df2782d
Compare
|
@fabriziosestito @flavio @viccuad can you review it again? I've noticed that the golangci.yml file that I've added in this PR was not the latest one. I've copied the version from spinkube repository. Now, I've copied the one from Marat Reymers gist and fix everything new that shown up. |
viccuad
approved these changes
Jul 15, 2024
fabriziosestito
approved these changes
Jul 15, 2024
flavio
approved these changes
Jul 15, 2024
Updates the golang linter configuration to be more stricter. The used configuration is originally written by Marat Reymers Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Adapts the golden config for golang linter from Marat Reymers to the Kubewarden project. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Removes an issue spot by the Go lang linter about using a global variable. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Fix the code base after updating the Golang linter configuration. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Go lang linter to stricter configuration. Also, updates the controller code to make the linter happy again.
Fix #778
Test
Additional Information
I've removed some
exclude-rulesnot used from the suggested configuration file to be used. As well as, disabled thetestpackagelinter. I don't think we need it for now.Keep in mind that some changed lines are
go fmtoutput. ;)