Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix container-build workflow, no need to set permissions #843

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Aug 12, 2024

Description

Introduced with CLOMonitor changes.
See
https://github.com/kubewarden/kubewarden-controller/actions/runs/10352202900/workflow

Test

CI once in main.

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad requested a review from a team as a code owner August 12, 2024 14:04
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.49%. Comparing base (90718e9) to head (9e5472b).

❗ There is a different number of reports uploaded between BASE (90718e9) and HEAD (9e5472b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (90718e9) HEAD (9e5472b)
unit-tests 2 1
integration-tests 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #843       +/-   ##
===========================================
- Coverage   71.57%   41.49%   -30.08%     
===========================================
  Files          21       11       -10     
  Lines        1998      547     -1451     
===========================================
- Hits         1430      227     -1203     
+ Misses        447      298      -149     
+ Partials      121       22       -99     
Flag Coverage Δ
integration-tests ?
unit-tests 41.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flavio flavio merged commit afda1a8 into kubewarden:main Aug 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants