Fixed teardown function of private-registry-test #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viccuad
reviewed
May 4, 2023
| @@ -5,7 +5,7 @@ metadata: | |||
| name: psp-user-group-disabled | |||
| spec: | |||
| policyServer: default | |||
| module: registry://ghcr.io/kubewarden/tests/psp-user-group:v0.1.1 | |||
| module: registry://ghcr.io/kubewarden/tests/user-group-psp:v0.4.7 | |||
There was a problem hiding this comment.
does this mean that we can delete the old package psp-user-group?
https://github.com/orgs/kubewarden/packages/container/package/tests%2Fpsp-user-group
There was a problem hiding this comment.
I don't know if it's used for anything else than e2e tests - if not we can delete it
- Updated test module versions - Added readme about cosign required by some tests Signed-off-by: Martin Kravec <kravciak@gmail.com>
|
I changed the visibility of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test: https://github.com/kubewarden/kubewarden-controller/actions/runs/4877745524/jobs/8702731582
Fixed run: https://github.com/kravciak/kubewarden-controller/actions/runs/4885861780/jobs/8720531929
Bugs reported:
Deleting policyServer.imagePullSecret puts kubewarden resource versions out of sync kubewarden-controller#443
Removing pull secret by helm has no effect on running policy server policy-server#459
Updated test module versions
Added readme about cosign required by some tests