Add ExtractPodSpecFromObject

[KhaledEmaraDev]

Description

New method for retrieving a PodSpec given you pass a high level object. Objects supported are: Deployment, ReplicaSet, StatefulSet, DaemonSet, ReplicationController, Job, CronJob, Pod.

This simplifies the evaluation of high level objects. A policy author just need to call this new method and evaluate the PodSpec returned. With this change pod-privileged-policy will reject high level objects (e.g Deployments) instead of allowing them and later rejects the pods

This is to map the Rust feature according to this issue.

Fix #36

Test

Additional Information

Tradeoff

Potential improvement

[flavio]

Thanks for your contribution. This LGTM, I just have left an open question. Let's see what the other @kubewarden/kubewarden-developers think about it

[viccuad]

Thanks for this PR!

It looks good, but I would put the new ExtractPodSpecFromObject() in kubewarden.go, and not in testing/helpers.go, as this function is a normal lib function that will be consumed by policies.

I would like to have some unit tests too, analogous to https://github.com/kubewarden/policy-sdk-rust/blob/main/src/lib.rs#L397-L674. Would you be up for the task?

[KhaledEmaraDev]

Thanks for this PR!

It looks good, but I would put the new ExtractPodSpecFromObject() in kubewarden.go, and not in testing/helpers.go, as this function is a normal lib function that will be consumed by policies.

I would like to have some unit tests too, analogous to https://github.com/kubewarden/policy-sdk-rust/blob/main/src/lib.rs#L397-L674. Would you be up for the task?

Yes, I'm up for it. I'll start working on it.

[KhaledEmaraDev]

@flavio @viccuad I have implemented the tests as agreed and moved the function to the correct place.

CC: @kubewarden/kubewarden-developers

[flavio]

On top of the comments I left, I think there's a lot of repetition inside of the kubewarden_test.go, maybe you could make everything more readable using a table driven approach (this is the 1st link I found about the topic)

[KhaledEmaraDev]

@flavio Resolved all comments and ran the tests successfully.

CC: @kubewarden/kubewarden-developers

[viccuad]

LGTM! Many thanks for tackling this and contributing to the SDK, merging!

[viccuad]

This is now available on https://github.com/kubewarden/policy-sdk-go/releases/tag/v0.2.4.