Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump OpenTelemetry version to 0.24. #835

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Jul 22, 2024

Description

Updates the OpenTelemetry version in use to v0.24.

Updates the OpenTelemetry version in use to v0.24.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
@jvanz
Copy link
Member Author

jvanz commented Jul 22, 2024

FYI: I'm testing manually the tracing generation.

Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I remember dealing with the tracer_provider when I gave it a try without the needed tracing-opentelemetry. At some point we will need to refactor once they deprecate even more things, but is not yet the time.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.38%. Comparing base (dc626a5) to head (f36499d).
Report is 2 commits behind head on main.

Files Patch % Lines
src/tracing.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   61.54%   61.38%   -0.16%     
==========================================
  Files          17       17              
  Lines        1035     1036       +1     
==========================================
- Hits          637      636       -1     
- Misses        398      400       +2     
Flag Coverage Δ
integration-tests 53.81% <0.00%> (-0.15%) ⬇️
unit-tests 33.16% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvanz
Copy link
Member Author

jvanz commented Jul 22, 2024

Traces are working
image

@jvanz jvanz merged commit 2489e48 into kubewarden:main Jul 22, 2024
9 of 11 checks passed
@jvanz jvanz deleted the optel-bump branch July 22, 2024 15:06
@jvanz jvanz mentioned this pull request Jul 26, 2024
jvanz added a commit to jvanz/policy-server that referenced this pull request Jul 26, 2024
This reverts commit 2489e48, reversing
changes made to 7e88c33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants