fix(scheduler): prevents scheduling new replicas to terminating clusters #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 28.59% 28.71% +0.11%
==========================================
Files 113 113
Lines 13549 13570 +21
==========================================
+ Hits 3875 3896 +21
Misses 9292 9292
Partials 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JackZxj
force-pushed
the
fix/prevent-terminating-cluster
branch
from
2219b67 to
026c6d6
Compare
mrlihanbo
approved these changes
Nov 9, 2023
limhawjia
approved these changes
Nov 10, 2023
gary-lgy
reviewed
Nov 10, 2023
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: clusterName, | ||
| }, | ||
| } | ||
| if terminating { | ||
| cluster.DeletionTimestamp = &metav1.Time{Time: time.Now()} |
There was a problem hiding this comment.
nit (no need to change it for this PR): could simplify this to metav1.Now
gary-lgy
reviewed
Nov 10, 2023
| su *framework.SchedulingUnit, | ||
| clusters []*fedcorev1a1.FederatedCluster, | ||
| ) { | ||
| for _, cluster := range clusters { |
There was a problem hiding this comment.
Should we run this regardless of scheduling mode?
gary-lgy
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current scheduler does not filter clusters being deleted because it may be necessary to retain resources in member clusters. However, this situation resulted in:
filterandscore.The scheduler may schedule new replicas to this terminating cluster. However the sync controller will not dispatch resources to the terminating clusters. This will cause the workload to fail to scale up in federation.
This PR ensures that the terminating cluster will not scale up by setting
MaxReplicasfor the terminating cluster. Specifically:When the
MaxClustersexists at the same time, the scheduler will also give priority to non-terminated clusters when scheduling is triggered, specifically: