optimize: add probe for cluster status #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 33.63% 33.55% -0.08%
==========================================
Files 156 157 +1
Lines 18052 18104 +52
==========================================
+ Hits 6071 6075 +4
- Misses 11460 11507 +47
- Partials 521 522 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wy-lucky
force-pushed
the
main
branch
2 times, most recently
from
085683e to
25814d7
Compare
Poor12
reviewed
Dec 17, 2024
| probeTimestamp: now, | ||
| } | ||
| } | ||
| c.update(cluster.Name, saved) |
There was a problem hiding this comment.
Do we need to update when saved.status == observed.Status?
There was a problem hiding this comment.
It's only needed when saved.status == observed.Status.The code has been updated.
Poor12
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster status may become abnormal due to a single network jitter. If this occurs while the application is in the scheduling state, it may lead to the application not being dispatched to that cluster. Therefore, we have optimized this by adding a detection mechanism for the cluster status to prevent unexpected scheduling results caused by a single network jitter.