forked from microsoft/fluentui
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(libuv): fix sporadic
libuv
assertion fails
The fix turns out to be bumping `webpack` from `4.43` to `4.44` in `packages/web-components`. Prior to this, I'd experience sporadic errors when running `yarn test` like the ones documented in this `karma` issue: [karma-runner/karma#3511](karma-runner/karma#3511). It turns out, that the problem is not with `karma` but rather with `webpack` as documented in [webpack/webpack#10037](webpack/webpack#10037). As per the closing comment in that issue, ensure we use `watchpack` version `^1.7.2` (a transitive dep of `webpack`) is enough to ensure this sporadic error goes away, and to bump `watchpack` we need to bump `webpack` by one minor version.
- Loading branch information
Jakub Konka
committed
Jan 18, 2021
1 parent
0229138
commit 96708e5
Showing
3 changed files
with
101 additions
and
2 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
change/@fluentui-web-components-2021-01-18-14-20-53-bump-webpack-webcomponents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "fix(libuv): fix sporadic `libuv` assertion fails", | ||
"packageName": "@fluentui/web-components", | ||
"email": "jakubkonka@microsoft.com", | ||
"dependentChangeType": "patch", | ||
"date": "2021-01-18T13:20:53.458Z" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters