Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version tag for bower install, plz #59

Closed
avdeev opened this issue Jul 12, 2016 · 9 comments
Closed

Add version tag for bower install, plz #59

avdeev opened this issue Jul 12, 2016 · 9 comments

Comments

@avdeev
Copy link

avdeev commented Jul 12, 2016

No description provided.

@ghost
Copy link

ghost commented Sep 9, 2016

👍

@DaSchTour
Copy link

As mentioned in #18, #37, #50

@ghost
Copy link

ghost commented Sep 13, 2016

well yes, but why there aren't any tags in git? Having in bower.json:

"dependencies": {
    "smart-app-banner": "1.3.0"
  }

ends up with an error:

bower smart-app-banner#1.3.0       not-cached https://github.com/kudago/smart-app-banner.git#1.3.0
bower smart-app-banner#1.3.0          resolve https://github.com/kudago/smart-app-banner.git#1.3.0
bower smart-app-banner#1.3.0     ENORESTARGET No tag found that was able to satisfy 1.3.0

Additional error details:
No versions found in https://github.com/kudago/smart-app-banner.git

Please add corresponding tags to git repository, just like here: https://libraries.io/bower/android-app-banner/tags (https://github.com/SpartzInc/android-app-banner/tags)

@DaSchTour
Copy link

DaSchTour commented Sep 13, 2016

Because nobody added git tags. No proper release workflow.

@ghost
Copy link

ghost commented Sep 14, 2016

@dfcreative could you please publish tags for this repo?

git clone https://github.com/kudago/smart-app-banner.git

git tag -a v1.0.0 -m "Version 1.0.0" 4fd8a7876c118e392274c64dd9d0a6ee89b16674
git push origin v1.0.0

git tag -a v1.3.0 -m "Version 1.3.0" 15aabbf49f737db61526429c525de3ec5a730964
git push origin v1.3.0

Thanks. I also created PR #63 so that repo could be added to travis-ci and automating version publishing for bower and npm.

@dy
Copy link
Member

dy commented Sep 14, 2016

Pushed tags. Please tell if it worked.

@ghost
Copy link

ghost commented Sep 20, 2016

Thanks a lot! Works great now.

I think now we can close #18, #37, #59

@dy
Copy link
Member

dy commented Sep 20, 2016

Great!

@ein-bandit
Copy link

need more tags please. missing all tags in bower since 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants