Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails if a pull request is behind the tip of master #230

Closed
jbarrick-mesosphere opened this issue May 10, 2019 · 0 comments · Fixed by #231
Closed

CI fails if a pull request is behind the tip of master #230

jbarrick-mesosphere opened this issue May 10, 2019 · 0 comments · Fixed by #231
Labels

Comments

@jbarrick-mesosphere
Copy link
Member

jbarrick-mesosphere commented May 10, 2019

What happened:

My PR was behind the tip of master and so CI fails with a cryptic error: https://circleci.com/gh/kudobuilder/kudo/451?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

#!/bin/bash -eo pipefail
git merge origin/master


*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'root@b16b0e0b495e.(none)')
Exited with code 128

What you expected to happen:

CI should either pass, or give an error indicating I should rebase.

How to reproduce it (as minimally and precisely as possible):

git fetch origin master
git checkout -b ci-fail
git reset --hard origin/master^1
echo hello > keps/draft-ci-fail.md
git add keps/draft-ci-fail.md
git commit -m 'a commit'
git push $remote ci-fail
jbarrick-mesosphere added a commit to jbarrick-mesosphere/kudo that referenced this issue May 10, 2019
Fixes kudobuilder#230.

Instead of merging master into the PR, we merge the PR into master to check the merge formatting.
jbarrick-mesosphere added a commit to jbarrick-mesosphere/kudo that referenced this issue May 10, 2019
Fixes kudobuilder#230.

We set the user name and email and a commit message in case a merge commit needs to be created.
alenkacz pushed a commit that referenced this issue May 23, 2019
Fixes #230.

We set the user name and email and a commit message in case a merge commit needs to be created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant