Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention how to get imports right in IDEA or Goland. #1242

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Mention how to get imports right in IDEA or Goland. #1242

merged 6 commits into from
Jan 9, 2020

Conversation

porridge
Copy link
Member

@porridge porridge commented Jan 2, 2020

No description provided.

@porridge
Mention how to get imports right in IDEA or Goland.
cb429cc 
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
alenkacz
alenkacz approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

zen-dog
zen-dog requested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of image files in the project root. Can we move it to some image hosting? Or simply mention all relevant settings in the text (shouldn't be much)

@porridge
Copy link
Member Author

porridge commented Jan 3, 2020

I'm not a big fan of image files in the project root.

@zen-dog what are the downsides of that?

Can we move it to some image hosting?

Can you point me to a good one?

@ANeumann82
Copy link
Member

Not a big fan of imgs in the project root as well - One might be fine, but it introduces clutter, from my point of view.
Don't really like the idea of an external image hosting either, though - that introduces external dependencies.

Can't we put images in some subfolder? That would work for me, not sure if that would work for @zen-dog

zen-dog
zen-dog reviewed Jan 6, 2020
View reviewed changes
STYLEGUIDE.md Outdated Show resolved Hide resolved
@zen-dog
Copy link
Contributor

zen-dog commented Jan 6, 2020

what are the downsides of that?

Expectations, I guess. Files in the root are sort of _project-global: .gitignore, README, Makefile, go.mod... you get the idea. Seeing some random image file strikes me as "garbage". Anyway, I typed it it in as a suggestion, so this shouldn't be an issue.

porridge and others added 4 commits January 8, 2020 10:36
@porridge
Update STYLEGUIDE.md
39c7240 
Co-Authored-By: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
@porridge
Say where.
f4e0f48
@porridge
Preformatted
5857c2e
@porridge
rm-image
7247297
@porridge porridge requested a review from zen-dog January 8, 2020 09:41
zen-dog
zen-dog approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@porridge porridge merged commit 08f299e into master Jan 9, 2020
@porridge porridge deleted the intellij-imports branch January 9, 2020 07:34
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
@porridge @ANeumann82
Mention how to get imports right in IDEA or Goland. (#1242)
05c95ff 
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
Co-Authored-By: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@alenkacz alenkacz alenkacz approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@nfnt nfnt Awaiting requested review from nfnt nfnt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@porridge @ANeumann82 @zen-dog @alenkacz