-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow simultaneous upgrade and parameter update #1495
Conversation
if `deploy` plan is triggered by the update. This seems to be a reasonable exception, since `deploy` plan is used for upgrades in many cases anyway. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although I think we may need to clear up all the rules around param triggers and OV upgrades and enfore them in package verify
Name: "bar", | ||
Trigger: update, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually allowed? I thought an update is only performed if the OV changes, and doesn't have anything to do with param changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we established these rules. It's all a bit fuzzy and determined by some old code. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should establish some rules to remove the fuzziness. We shouldn't have legacy code that drives behavior we don't fully understand in a project that's still in beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's also document these behaviors in https://kudo.dev/docs/developing-operators/plans.html.
Name: "bar", | ||
Trigger: update, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should establish some rules to remove the fuzziness. We shouldn't have legacy code that drives behavior we don't fully understand in a project that's still in beta.
I agree. Like I don't quite buy the special |
if the
deploy
plan is triggered by the update. This seems to be a reasonable exception since thedeploy
plan is used for upgrades in many cases anyway.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com