-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-31: Namespace Management #1496
Conversation
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Nice KEP! I'd really like to already see a "User Stories" section where we can describe some expectations already - and then we can decide if something is reasonable or not. I have at least a couple in mind:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks for all the details of namespace management.
I added a few comments that already reflect my preference to not create namespaces in KUDO. In my opinion creating and deleting namespaces is a responsibility of the cluster admins that know best about the topology of different teams and projects in the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, however, I'd like for us to be explicit about namespace creation (see my comment about the rules)
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff @kensipe !
LGTM as the first version of KEP and we might add more proposals later or go more in details in some alternatives
Some added context for multi-namespace support:
|
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits and typos, one addition/clarification to the rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few grammar nits but otherwise 🚢
Co-authored-by: Andreas Neumann <aneumann@mesosphere.com> Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe kensipe@gmail.com