-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override the pull policy of the controller in 'kudo init' #1507
Conversation
This makes it easier to deploy KUDO in test environments where a KUDO image is available in the cluster but not in any repository. Signed-off-by: Jan Schlicht <jan@d2iq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, i've had to add that in my init --upgrade branch as well, but better to have it here in a separate PR.
I would prefer a more distinctive name, but that's not a blocker for me.
The missing validation for the pullPolicy is though ;)
Signed-off-by: Jan Schlicht <jan@d2iq.com> Co-authored-by: Andreas Neumann <aneumann@mesosphere.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to add flags to control individual fields of the output YAML even if it gets rid of the sed
in tests 🤔 But it certainly needs more validation.
Signed-off-by: Jan Schlicht <jan@d2iq.com>
We actually need this. For these tests it works with the |
Signed-off-by: Jan Schlicht <jan@d2iq.com> Co-authored-by: Andreas Neumann <aneumann@mesosphere.com>
What this PR does / why we need it:
This makes it easier to deploy KUDO in test environments where a KUDO image is available in the cluster but not in any repository.