KEP-31: Impl of --create-namespace
#1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com> I think annotations are good Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
This PR was originally opped with #1529 and has been open for several days... with approvals in place... merging... |
zen-dog
reviewed
May 19, 2020
| } | ||
| ns.TypeMeta.Kind = "Namespace" | ||
| ns.Name = namespace | ||
| ns.Annotations["created-by"] = "kudo-cli" |
There was a problem hiding this comment.
What is this annotation needed for? And if it's actually needed, let's put it into labels.go with other annotations and prefix it with kudo.dev/???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working version of
--create-namespacewith namespaceManifest file as defined in KEP 31Tests still need to be added but it is tested fully functional with errors on namespace exits and with and without provided manifest file.
Properly need to test with corrupt manifest file ++
IMPORTANT CONTEXT:
--create-namespacefunctionality and a) creates a namespace, b) fails if it exists and c) creates a namespace with manifestFixes #
Signed-off-by: Ken Sipe kensipe@gmail.com