KEP31: Template Support for Namespace Manifest #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
ANeumann82
approved these changes
May 25, 2020
pkg/kudoctl/util/kudo/install.go
Outdated
Comment on lines
157
to
162
| configs["OperatorName"] = resources.Operator.Name | ||
| configs["Name"] = instanceName | ||
| configs["Namespace"] = namespace | ||
| configs["Params"] = parameters | ||
| configs["AppVersion"] = resources.OperatorVersion.Spec.AppVersion | ||
| configs["OperatorVersion"] = resources.OperatorVersion.Spec.Version |
There was a problem hiding this comment.
I wonder if we could somehow put these and the assignments from render.go:15-25 together. Or maybe at least define constants for the strings here.
Reason is that when at some point we add some more variables for templating, it might be easy to miss one of the places.
There was a problem hiding this comment.
we actually have in 3 parts of code I discovered... makes sense to me
pkg/kudoctl/util/kudo/install.go
Outdated
| var err error | ||
| manifest, err = render("namespace", template, resources, instanceName, namespace, parameters) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| return fmt.Errorf("failed to render namespace manifest %s: %v", resources.Operator.Spec.NamespaceManifest, err) |
Might be good to add some context to the error here?
Signed-off-by: Ken Sipe <kensipe@gmail.com>
…ce in code Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Sipe kensipe@gmail.com
Fixes #