Pod health should be checking for readiness #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
requested review from
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
lgtm, although you need to add a PodRunningCondition in |
alenkacz
changed the title
|
@ANeumann82 thanks, you're the best :D |
zen-dog
approved these changes
Aug 20, 2020
| @@ -106,7 +108,7 @@ func IsHealthy(obj runtime.Object) error { | |||
| return fmt.Errorf("instance %s/%s active plan is in state %v", obj.Namespace, obj.Name, obj.Spec.PlanExecution.Status) | |||
|
|
|||
| case *corev1.Pod: | |||
| if obj.Status.Phase == corev1.PodRunning { | |||
| if obj.Status.Phase == corev1.PodRunning && podutils.IsPodReady(obj) { | |||
There was a problem hiding this comment.
Do we still need both conditions to be true? Isn't podutils.IsPodReady(obj) enough?
There was a problem hiding this comment.
I did not have that in the first version but in the end I ended up doing exactly what StatefulSet is doing to be on the safe side https://github.com/kubernetes/kubernetes/blob/60044a8accfe8fddeb452c4adca4fefbbff64967/pkg/controller/statefulset/stateful_set_utils.go#L204
nfnt
approved these changes
Aug 21, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> # Conflicts: # pkg/engine/health/health.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alena Varkockova varkockova.a@gmail.com
What this PR does / why we need it:
We already use ready condition when evaluating health of statefulset we should do it for pods as well. Running condition is not enough as the container might be just starting also it does not include waiting for the readiness checks.
See https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ for more context. Also see how StatefulSet evaluates what goes into
readyReplicashttps://github.com/kubernetes/kubernetes/blob/60044a8accfe8fddeb452c4adca4fefbbff64967/pkg/controller/statefulset/stateful_set_utils.go#L204Fixes #