Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run the CRD validation if validation flag is false #1720

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Don't run the CRD validation if validation flag is false #1720

merged 1 commit into from
Oct 16, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Oct 16, 2020 •
edited
Loading

What this PR does / why we need it:
CRD validation can result in warning logs on Kubernetes >=1.19. These should be skipped if running commands with '--validate-install=false'.

Before:

$ kubectl kudo --validate-install=false get instances
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
List of current installed instances in namespace "default":
.

After:

$ kubectl kudo --validate-install=false get instances
List of current installed instances in namespace "default":
.

Don't run the CRD validation if validation flag is false.
1f6a59c 
CRD validation can result in warning logs. These should be skipped if running commands with '--validate-install=false'.

Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt requested a review from ANeumann82 October 16, 2020 09:21
@nfnt nfnt self-assigned this Oct 16, 2020
alenkacz
alenkacz approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👏

ANeumann82
ANeumann82 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice... Yeah...

kensipe
kensipe approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nfnt nfnt merged commit 68605c2 into main Oct 16, 2020
@nfnt nfnt deleted the nfnt/dont-always-validate branch October 16, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@alenkacz alenkacz alenkacz approved these changes

@kensipe kensipe kensipe approved these changes

@gerred gerred Awaiting requested review from gerred

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees

@nfnt nfnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nfnt @kensipe @alenkacz @ANeumann82