Required Kustomize Config Change #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerred
approved these changes
Apr 15, 2019
|
What we probably also should do is adding |
fabianbaier
reviewed
Apr 15, 2019
This was referenced Apr 15, 2019
|
thanks for the review @fabianbaier and catching the extra files! |
kensipe
force-pushed
the
ken/kustomize-layout
branch
from
ff0990a to
1acde68
Compare
fabianbaier
reviewed
Apr 15, 2019
| @@ -20,6 +20,7 @@ Before you get started: | |||
| - Latest version of `dep` | |||
| - Kubernetes Cluster `1.12` or later (e.g. [Minikube](https://kubernetes.io/docs/tasks/tools/install-minikube/)) | |||
| - [Install kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) with version `1.12` or later | |||
| - [Install Kustomize](https://github.com/kubernetes-sigs/kustomize/blob/master/docs/INSTALL.md) | |||
There was a problem hiding this comment.
maybe pinpointing the version as well?
- Install Kustomize with version
2.0.3or later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Kustomize requires resource paths to be in the configuration directory or sub-directory.
rbacandmanagerconfigs were moved underdefaultWe will not be able to reuse
rbacconfigurations unless we move to building out a "scratch" or output directory to manipulate files.Which issue(s) this PR fixes:
Fixes #189
Special notes for your reviewer:
Does this PR introduce a user-facing change?: