-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Framework to Operator #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration test pass. test-harness fails
kensipe
requested review from
alenkacz,
fabianbaier,
gerred,
guenter,
jbarrick-mesosphere and
runyontr
as code owners
June 27, 2019 20:48
jbarrick-mesosphere
approved these changes
Jun 27, 2019
kensipe
commented
Jun 27, 2019
@@ -51,7 +51,7 @@ Or you can use compile and install the plugin from your `$GOPATH/src/github.com/ | |||
|
|||
| Syntax | Description | | |||
| ------------------------------------------ | --------------------------------------------------------------------------------------------- | | |||
| `kubectl kudo install <name> [flags]` | Install a Framework from the official [KUDO repo](https://github.com/kudobuilder/frameworks). | | |||
| `kubectl kudo install <name> [flags]` | Install a Operator from the official [KUDO repo](https://github.com/kudobuilder/operators). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we are going to make this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya. is the URL updated in the repo codebase as well for this?
gerred
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Switches all references from framework to operator. This includes all CRDs and code. It includes all docs and links. All tests run and pass. I expect that the url references to repo are correct but are not implemented yet. (repo/operators)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: