No panic when getting a plan status for an instance with no plan #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain edge case situations (like a controller outage) an instance might not have an `activePlan.status` set. This fixes a cli panic when querying a plan status for such an instance. Issues: #459
zen-dog
commented
Jun 28, 2019
| @@ -621,3 +622,8 @@ func (r *ReconcilePlanExecution) Cleanup(obj runtime.Object) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is unrelated to the bug, just making our lives easier when debugging integration tests.
kensipe
approved these changes
Jun 28, 2019
| func prettyPrint(i interface{}) string { | ||
| s, _ := json.MarshalIndent(i, "", " ") | ||
| return string(s) | ||
| } |
There was a problem hiding this comment.
shouldn't this be in a json util package? this is not planexec specific
There was a problem hiding this comment.
as I reason through this more... this function literal swallows the err. what is the output for an error? do we not want any indication there was an error?
There was a problem hiding this comment.
That's why I haven't put it into util package - I didn't want a general purpose prettyPrint method for everybody (though it can be). So far, I only saw planexecution_controller printing gigantic yaml object in our logs.
alenkacz
pushed a commit
that referenced
this pull request
Jul 9, 2019
In certain edge case situations (like a controller outage) an instance might not have an `activePlan.status` set. This fixes a cli panic when querying a plan status for such an instance. Issues: #459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In certain edge case situations (like a controller outage) an instance might not have an
activePlan.statusset. This fixes a cli-panic when querying a plan status for such an instance.Which issue(s) this PR fixes:
Fixes #459
Special notes for your reviewer:
Does this PR introduce a user-facing change?: