Support --skip-delete to skip deletion of resources created during tests #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts. This helps with debugging tests. Fixes kudobuilder#377. Also refactors the test harness CLI parsing to load configuration: 1. If `--config` is set, from the config specified. 2. If `--config` is not set and `kudo-test.yaml` exists, it loads it from `kudo-test.yaml`. 3. Arguments set on the command line override configuration from the configuration. Previously you could only use CLI arguments or a configuration.
jbarrick-mesosphere
requested review from
alenkacz,
fabianbaier,
gerred,
kensipe and
runyontr
as code owners
alenkacz
reviewed
Jul 2, 2019
| @@ -86,6 +87,30 @@ For more detailed documentation, visit: https://kudo.dev/docs/testing`, | |||
| } | |||
| } | |||
|
|
|||
| if isSet(flags, "crd-dir") { | |||
There was a problem hiding this comment.
🤔 what is the benefit of this vs having options.CRDDir directly in testCmd.Flags().StringVar? If not set, you'll have the default value for that type anyway, right? I guess it at least deserves a comment since it's not obvious (at least to me)
There was a problem hiding this comment.
For consistency, mainly. It's more important below with the booleans - I want to know the difference between not set, false, and true.
There was a problem hiding this comment.
Added some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support --skip-delete to skip deletion of resources created during tests.
This helps with debugging tests.
Also refactors the test harness CLI parsing to load configuration:
--configis set, from the config specified.--configis not set andkudo-test.yamlexists, it loads it fromkudo-test.yaml.Previously you could only use CLI arguments or a configuration.
Which issue(s) this PR fixes:
Fixes #377
Special notes for your reviewer:
Does this PR introduce a user-facing change?: