Use kubeconfig flag set at root for subcommands #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
force-pushed
the
njones/kubeconfig_root
branch
from
bbf6aea to
e45cb3a
Compare
yankcrime
requested review from
alenkacz,
fabianbaier and
kensipe
as code owners
We handle setting an appropriate default for the user's Kubernetes cluster configuration file elsewhere.
yankcrime
force-pushed
the
njones/kubeconfig_root
branch
from
43139f7 to
5391a20
Compare
kensipe
approved these changes
Jul 15, 2019
alenkacz
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/component kudoctl
What this PR does / why we need it:
Move the use of the
--kubeconfigflag out to the root of the command structure. If unset, it defaults to~/.kube/configor uses the value of theKUBECONFIGshell environment variable.Which issue(s) this PR fixes:
Fixes #560
Does this PR introduce a user-facing change?: