Prefix our labels and annotations #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
requested review from
fabianbaier,
gerred,
kensipe and
runyontr
as code owners
gerred
approved these changes
Jul 18, 2019
kensipe
approved these changes
Jul 18, 2019
jbarrick-mesosphere
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
It is a best practice among tools in k8s ecosystem to prefix their labels and annotations with a dns name, that identifies the owner. That way version or name label introduced by one tool does not clash with the same labels introduced by other tools.
Which issue(s) this PR fixes:
Fixes #539
Special notes for your reviewer:
Does this PR introduce a user-facing change?: