Extract all kustomize logic to a separate file #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome. Will it come with tests on apply conventions before we merge or do you think this needs more refactoring to become testable? |
gerred
approved these changes
Jul 18, 2019
gerred
approved these changes
Jul 18, 2019
|
@gerred yeah, tests are coming :) I wanted to put it out there to see if people like it, but with this "interface" writing tests will be very easy :) |
jbarrick-mesosphere
approved these changes
Jul 18, 2019
|
omg I screwed up the branches 🙈 this should not contain the namespace changes, I'll clean it up... |
This reverts commit 2a19de6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is like a drop of water in the ocean considering the overall state of planexecution controller but we have to start somewhere. This extracts part of logic out of planexecution controller. This logic is using kustomize to apply conventions to templates before adding them to kubernetes.
Fixes #601