Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer Maintainer Metadata #762

Merged
merged 5 commits into from
Sep 11, 2019
Merged

Richer Maintainer Metadata #762

merged 5 commits into from
Sep 11, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Sep 6, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Fixes Operator Maintainer Metadata to be more rich

Which issue(s) this PR fixes:
Fixes #752

Special notes for your reviewer:
This will break existing operators

Does this PR introduce a user-facing change?:


@kudo-ci
Copy link

kudo-ci commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alenkacz
Copy link
Contributor

alenkacz commented Sep 6, 2019

/retest

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I am just rejecting because I understood we agreed we won't break CRDs in this release and we're going to wait for the one with new controller CRDs

@gerred
Copy link
Member

gerred commented Sep 6, 2019

LGTM. Assigned it as the first thing in the 0.7.0 milestone! 🎉

@gerred gerred added this to the 0.7.0 milestone Sep 6, 2019
@kensipe kensipe added the hold label Sep 6, 2019
@kensipe kensipe force-pushed the ken/maintainer branch 2 times, most recently from 79ada8f to 20ddd7e Compare September 11, 2019 14:58
@kensipe kensipe removed the hold label Sep 11, 2019
@kensipe kensipe merged commit d733387 into master Sep 11, 2019
@kudo-ci kudo-ci deleted the ken/maintainer branch September 11, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify maintainers in index file and operator CRD
4 participants