Add an integration test for the 'first-operator' example #828
Conversation
This ensures that changes in KUDO are reflected in this example.
| @@ -0,0 +1,6 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
Is the correct way to scale to update the deployment replicas directly?
There was a problem hiding this comment.
I'm following https://kudo.dev/docs/testing.html#writing-your-first-test here.
There was a problem hiding this comment.
The example shows how to adjust the replicas on a deployment when testing a deployment. You aren’t testing a deployment so would be writing a different test than the example...
There was a problem hiding this comment.
Oooh, Justin is 100% right, I think this test should adjust the replicas parameter value instead. Good catch @jbarrick-mesosphere !
|
So what do I have to do instead? Is the test documentation not up-to-date and needs to be changed? |
|
I'm now scaling like it's done in |
nfnt
force-pushed
the
nfnt/test-first-operator-example
branch
from
5e4f049 to
2a013a9
Compare
What type of PR is this?
/kind enhancement
/kind test
What this PR does / why we need it:
This ensures that changes in KUDO are reflected in this example.
Which issue(s) this PR fixes:
Fixes #827
Special notes for your reviewer:
Does this PR introduce a user-facing change?: