Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Aggregated Status #251

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Removal of Aggregated Status #251

merged 2 commits into from
Apr 20, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Apr 17, 2020

Based on kudobuilder/kudo#1474
This status will be removed

Signed-off-by: Ken Sipe kensipe@gmail.com

kensipe added 2 commits April 17, 2020 12:10
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zen-dog
Copy link
Contributor

zen-dog commented Apr 17, 2020

Even without kudobuilder/kudo#1474 this is still an improvement: instead of reacting to any complete plan (in the aggregateStatus) we specify the exact plan.

@kensipe
Copy link
Member Author

kensipe commented Apr 17, 2020

agree! in fact I thought about writing the same thing :)

@zen-dog zen-dog merged commit a2a406b into master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants