-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support ESLint v8 #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diescake
requested review from
nabeliwo and
negiandleek
and removed request for
a team,
nabeliwo and
negiandleek
October 28, 2021 12:06
diescake
changed the title
[WIP] chore: remove the node v10 build and add the v14 build on CircleCI
chore: remove the node v10 build and add the v14 build on CircleCI
Oct 28, 2021
diescake
changed the title
chore: remove the node v10 build and add the v14 build on CircleCI
chore: support ESLint v8
Oct 28, 2021
1 task
Jest hasn't supported the "jest": {
"moduleNameMapper": {
"eslint/use-at-your-own-risk": "eslint/lib/unsupported-api.js"
}
} I've found that |
diescake
force-pushed
the
migrate-eslint-to-v8
branch
2 times, most recently
from
November 11, 2021 14:56
b83c7e6
to
a4ec035
Compare
prevent unexpected updates of node versions in config.yml
- Jest hasn't supported the exports field yet, so we have to use a workaround some thing like this. - jestjs/jest#9771
diescake
force-pushed
the
migrate-eslint-to-v8
branch
from
November 11, 2021 15:03
a4ec035
to
7032222
Compare
diescake
requested review from
a team,
yt-ymmt and
MRTAFU
and removed request for
a team
November 11, 2021 15:04
This was referenced Nov 11, 2021
yt-ymmt
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:igyo: :lgtm:
@yt-ymmt あざます!! 1-approve いただけたのでマージします〜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
依存ライブラリを諸々アップデートして eslint-config-smarthr を ESLint v8 に対応させたい!
やったこと
$ yarn test でこんなエラーが発生していた。
TODO