Try to fix bug with filter assignment #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method _add_filter_number() was issuing redundant numbers when encountering multiple new, nameless filters. I tried to fixed this and created a branch (fix_issue_151) Also, note that if the filter has_a name, we do not assess whether or not it is new, ... is this OK?? I think so, because if it has_a name, it will be registered in ch_filter_dict which is returned by _xml_response_to_mt and then merged into the survey before the next channel is processed. Relates to issue #151
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## fcs #155 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 264 264
Lines 18329 18331 +2
=======================================
+ Hits 14983 14985 +2
Misses 3346 3346
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method _add_filter_number() was issuing redundant numbers when encountering multiple new, nameless filters. I tried to fixed this and created a branch (fix_issue_151)
Also, note that if the filter has_a name, we do not assess whether or not it is new, ... is this OK?? I think so, because if it has_a name, it will be registered in ch_filter_dict which is returned by _xml_response_to_mt and then merged into the survey before the next channel is processed.
Relates to issue #151