Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 105 #106

Merged
merged 15 commits into from
Aug 19, 2022
Merged

Fix issue 105 #106

merged 15 commits into from
Aug 19, 2022

Conversation

kkappler
Copy link
Collaborator

@kkappler kkappler commented Jul 4, 2022

Fix a bug in make_mth5 that allows making large CAS04 file with correct metadata. Needed to temporarily suppress warning C901 to get this to push.

@laura-iris this would be a good branch to work from when you are refactoring make_mth5

@kkappler
Copy link
Collaborator Author

kkappler commented Jul 29, 2022

Commit Fri 29 July, ~1500 Pacific:
2435402
Is passing make_mth5 tests locally.

We need to

  • Change the tests so that assertion

AssertionError: Lists differ: ['LFE', 'LFN', 'LFZ', 'LQE', 'LQN'] != ['LFE', 'LFN', 'LFZ', 'LQE', 'LQE', 'LQE', 'LQN', 'LQN']

Is using set equality not list equality.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #106 (0fcda96) into master (baa7753) will increase coverage by 0.95%.
The diff coverage is 62.24%.

❗ Current head 0fcda96 differs from pull request most recent head b81ee20. Consider uploading reports for the commit b81ee20 to get more accurate results

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   53.43%   54.38%   +0.95%     
==========================================
  Files          58       58              
  Lines        7502     7746     +244     
==========================================
+ Hits         4009     4213     +204     
- Misses       3493     3533      +40     
Impacted Files Coverage Δ
mth5/utils/helpers.py 0.00% <0.00%> (ø)
tests/version_1/test_make_mth5.py 93.67% <ø> (ø)
tests/version_2/test_make_mth5.py 93.42% <ø> (ø)
mth5/clients/make_mth5.py 65.80% <63.54%> (+3.01%) ⬆️
mth5/timeseries/run_ts.py 66.28% <0.00%> (-0.77%) ⬇️
mth5/mth5.py 68.30% <0.00%> (+6.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kujaku11 kujaku11 merged commit 22387bf into master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants