Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve selection bridge #24

Merged
merged 3 commits into from
Aug 15, 2023
Merged

refactor: improve selection bridge #24

merged 3 commits into from
Aug 15, 2023

Conversation

StevenEWright
Copy link
Contributor

@StevenEWright StevenEWright commented Aug 15, 2023

Gets rid of the remainder of the DOM management and now we have line metrics and line wrapping 🥳

In a follow up PR I will refactor gutters and highlights to handle #18 now that we have a source of truth for real line metrics.

**Github Issue List: ** closes #19

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
  • I <Signature> agree to the Developer Certificate of Origin
  • I have reviewed the License Agreement at
    LICENSE.md

Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

size-limit report 📦

Path Size
./dist/kullna-editor.min.js 6.7 KB (-1.14% 🔽)

Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@StevenEWright StevenEWright merged commit 24cc606 into main Aug 15, 2023
4 checks passed
@StevenEWright StevenEWright deleted the swright/selection branch August 15, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Selection Bridge
1 participant