Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throttled action bad logic #34

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

StevenEWright
Copy link
Contributor

@StevenEWright StevenEWright commented Aug 28, 2023

Fixes an issue with throttled_action which resulted in it failing to call the action if the action were throttled... which may explain some of the scrolling bugs.

Also added source links to the documentation.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
  • I Steven E Wright agree to the Developer Certificate of Origin
  • I have reviewed the License Agreement at
    LICENSE.md

Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@StevenEWright
Copy link
Contributor Author

I have read the DCO Document and I hereby sign the DCO

@github-actions
Copy link

size-limit report 📦

Path Size
./dist/kullna-editor.min.js 7.58 KB (0%)

@StevenEWright
Copy link
Contributor Author

recheck

2 similar comments
@StevenEWright
Copy link
Contributor Author

recheck

@StevenEWright
Copy link
Contributor Author

recheck

@StevenEWright StevenEWright merged commit b17eaf8 into main Aug 28, 2023
5 checks passed
@StevenEWright StevenEWright deleted the swright/fix_throttled_action branch August 28, 2023 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant