Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the internals of editor #9

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

StevenEWright
Copy link
Contributor

@StevenEWright StevenEWright commented Aug 6, 2023

This change brings the codebase into a state that reflects the direction we want to go. This is the first real iteration.

Pre-Review Checklist:

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
  • I <Signature> agree to the Developer Certificate of Origin
  • I have reviewed the License Agreement at LICENCE.md

Copy link
Contributor Author

@StevenEWright StevenEWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

echo Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/editor_events.ts Outdated Show resolved Hide resolved
src/editor_options.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/selection_manager.ts Outdated Show resolved Hide resolved
src/state_manager.ts Outdated Show resolved Hide resolved
@StevenEWright StevenEWright force-pushed the swright/router branch 18 times, most recently from e979b32 to 4c79456 Compare August 11, 2023 02:32
Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@StevenEWright StevenEWright merged commit 66fba92 into main Aug 11, 2023
1 of 4 checks passed
@StevenEWright StevenEWright deleted the swright/router branch August 11, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant