Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: commmonjs -> commonjs #285

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Conversation

lijunle
Copy link
Contributor

@lijunle lijunle commented Aug 1, 2017

No description provided.

Copy link
Contributor

@bcruddy bcruddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bcruddy bcruddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a patch bump in the package.json since it's a deployable code change. Thanks for the contribution!

@kulshekhar
Copy link
Owner

@lijunle Thanks for the PR. Be sure to add your name/email to the author list as well!

@GeeWee
Copy link
Collaborator

GeeWee commented Aug 2, 2017

Wow that's a pretty embarassing typo. Nice catch!

@kulshekhar
Copy link
Owner

I think we can merge this in and bundle it with a future release.

@azasypkin
Copy link

azasypkin commented Aug 4, 2017

I think we can merge this in and bundle it with a future release.

It actually didn't allow me to run any tests for one of my TS projects (that used deprecated but still supported __TSCONFIG__ global), so I'd say it should be released as soon as possible.

@kulshekhar
Copy link
Owner

so I'd say it should be released as soon as possible.

ok then!

@kulshekhar kulshekhar merged commit 93c0c88 into kulshekhar:master Aug 4, 2017
@lijunle lijunle deleted the patch-1 branch January 4, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants