Handle 'use strict' #71
Merged
+129
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igmat
reviewed
Dec 1, 2016
|
|
||
| .vscode | ||
| .idea | ||
| **/node_modules |
There was a problem hiding this comment.
It's a bad idea. We need that folder in each integration test case, because without it, you'll always test version from root node_modules.
There was a problem hiding this comment.
I'll fix that right away
|
|
||
| it('should show the error locations for "use strict" violations', () => { | ||
|
|
||
| const result = runJest('../use-strict', ['--no-cache', '-t', 'Invalid Strict']); |
There was a problem hiding this comment.
What does -t flag stands for? I haven't found any doc on that, and jest --help haven't shown nothing also.
There was a problem hiding this comment.
It runs a test that matches the name specified.
Running jest --help showed this part:
--testNamePattern, -t Run only tests with a name that matches the
regex pattern. [string]
There was a problem hiding this comment.
Really. My bad - somehow missed it.
There was a problem hiding this comment.
I found out about it today myself :)
Igmat
added a commit
that referenced
this pull request
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69