chore(deps): requires Node.js v18.13 (#548)

Requires Node.js v18.13 throughout the project to address a breaking change in v18.13 (see nodejs/node#46123). Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
kumahq · Jan 16, 2023 · a43f8cd · a43f8cd
1 parent aab2666
commit a43f8cd
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 16 deletions.
diff --git a/.github/workflows/create-gui-pr.yml b/.github/workflows/create-gui-pr.yml
@@ -36,7 +36,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: "18.12"
+          node-version: "18.13"
 
       - name: Cache node_modules and dist
         uses: actions/cache@v3

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -23,7 +23,7 @@ jobs:
         # https://github.com/actions/setup-node
         uses: actions/setup-node@v3
         with:
-          node-version: '18.12'
+          node-version: '18.13'
 
       - name: Cache node_modules and dist
         # https://github.com/actions/cache

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.12
+18.13
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
     "test:watch": "yarn run test --watch"
   },
   "engines": {
-    "node": ">=18 <18.13.0",
+    "node": ">=18.13",
     "yarn": "^1.22.0"
   },
   "dependencies": {

diff --git a/src/app/data-planes/components/DataPlaneDetails.spec.ts b/src/app/data-planes/components/DataPlaneDetails.spec.ts
@@ -37,7 +37,7 @@ describe('DataPlaneDetails', () => {
 
   test('has expected content and UI elements', async () => {
     const expectedOverviewStrings = ['DPP: backend', 'test-mesh', 'online', 'kuma.io/service', 'backend', 'kuma.io/protocol', 'http', 'envoy', '1.16.2', 'kumaDp', '1.0.7', 'coredns', '1.8.3']
-    const expectedInsightStrings = ['Connect time: February 17, 2021 at 7:33:36 AM', 'Control Plane Instance ID', 'Disconnect time: February 17, 2021 at 7:33:36 AM']
+    const expectedInsightStrings = ['Connect time: February 17, 2021 at 7:33:36 AM', 'Control Plane Instance ID', 'Disconnect time: February 17, 2021 at 7:33:36 AM']
     const expectedPoliciesStrings = ['web', '192.168.0.1:80:81', 'backend', 'fi1.kuma-system', 'web-to-backend.kuma-system']
 
     const wrapper = await renderComponent()

diff --git a/src/app/data-planes/components/__snapshots__/DataPlaneEntitySummary.spec.ts.snap b/src/app/data-planes/components/__snapshots__/DataPlaneEntitySummary.spec.ts.snap
@@ -140,7 +140,7 @@ exports[`DataPlaneEntitySummary matches snapshot 1`] = `
             Connect time:
           </span>
           <span>
-            February 17, 2021 at 7:33:36 AM
+            February 17, 2021 at 7:33:36 AM
           </span>
         </div>
         <div
@@ -225,7 +225,7 @@ exports[`DataPlaneEntitySummary matches snapshot 1`] = `
             Connect time:
           </span>
           <span>
-            February 17, 2021 at 7:33:36 AM
+            February 17, 2021 at 7:33:36 AM
           </span>
         </div>
         <div
@@ -236,7 +236,7 @@ exports[`DataPlaneEntitySummary matches snapshot 1`] = `
             Disconnect time:
           </span>
           <span>
-            February 17, 2021 at 7:33:36 AM
+            February 17, 2021 at 7:33:36 AM
           </span>
         </div>
         <div

diff --git a/src/app/data-planes/views/__snapshots__/DataPlaneListView.spec.ts.snap b/src/app/data-planes/views/__snapshots__/DataPlaneListView.spec.ts.snap
@@ -1896,7 +1896,7 @@ exports[`DataPlaneListView matches snapshot 1`] = `
                 Connect time:
               </span>
               <span>
-                February 17, 2021 at 7:33:36 AM
+                February 17, 2021 at 7:33:36 AM
               </span>
             </div>
             <div
@@ -1981,7 +1981,7 @@ exports[`DataPlaneListView matches snapshot 1`] = `
                 Connect time:
               </span>
               <span>
-                February 17, 2021 at 7:33:36 AM
+                February 17, 2021 at 7:33:36 AM
               </span>
             </div>
             <div
@@ -1992,7 +1992,7 @@ exports[`DataPlaneListView matches snapshot 1`] = `
                 Disconnect time:
               </span>
               <span>
-                February 17, 2021 at 7:33:36 AM
+                February 17, 2021 at 7:33:36 AM
               </span>
             </div>
             <div

diff --git a/src/app/zones/views/__snapshots__/ZoneEgresses.spec.ts.snap b/src/app/zones/views/__snapshots__/ZoneEgresses.spec.ts.snap
@@ -1000,7 +1000,7 @@ exports[`ZoneEgresses.vue renders zoneegress insights 1`] = `
                       <span
                         class="color-green-500"
                       >
-                         Connect time: July 13, 2021 at 8:41:04 AM
+                         Connect time: July 13, 2021 at 8:41:04 AM
                       </span>
                       <!--v-if-->
                     </h4>

diff --git a/src/app/zones/views/__snapshots__/ZoneIngresses.spec.ts.snap b/src/app/zones/views/__snapshots__/ZoneIngresses.spec.ts.snap
@@ -677,7 +677,7 @@ exports[`ZoneIngresses.vue renders zoneingress insights 1`] = `
                       <span
                         class="color-green-500"
                       >
-                         Connect time: July 13, 2021 at 8:41:04 AM
+                         Connect time: July 13, 2021 at 8:41:04 AM
                       </span>
                       <!--v-if-->
                     </h4>

diff --git a/src/app/zones/views/__snapshots__/ZonesView.spec.ts.snap b/src/app/zones/views/__snapshots__/ZonesView.spec.ts.snap
@@ -1262,7 +1262,7 @@ exports[`ZonesView.vue renders zone insights 1`] = `
                       <span
                         class="color-green-500"
                       >
-                         Connect time: February 19, 2021 at 7:11:15 AM
+                         Connect time: February 19, 2021 at 7:11:15 AM
                       </span>
                       <!--v-if-->
                     </h4>
@@ -1799,12 +1799,12 @@ exports[`ZonesView.vue renders zone insights 1`] = `
                       <span
                         class="color-green-500"
                       >
-                         Connect time: July 28, 2020 at 4:18:09 PM
+                         Connect time: July 28, 2020 at 4:18:09 PM
                       </span>
                       <span
                         class="ml-4 color-red-600"
                       >
-                         Disconnect time: July 28, 2020 at 4:18:09 PM
+                         Disconnect time: July 28, 2020 at 4:18:09 PM
                       </span>
                     </h4>